flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG
Date Mon, 21 Aug 2017 06:37:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134771#comment-16134771
] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r134119014
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -162,13 +172,66 @@ class AggregationCodeGenerator(
           }
         }
     
    +    def genDataViewFieldSetter(accTerm: String, specs: Seq[DataViewSpec[_]]): String
= {
    +      if (accConfig.isDefined && accConfig.get.isStateBackedDataViews) {
    +        val setters = for (spec <- specs) yield {
    +          val field = spec.field
    +          val dataViewTerm = s"${accTerm}_${field.getName}_dataview"
    --- End diff --
    
    I find that the dataview term is defined in many place, can we create a method to generate
the term name? such as `createDataViewTerm(index: Int, fieldName: String)`


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message