flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG
Date Fri, 25 Aug 2017 04:24:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141140#comment-16141140
] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user wuchong commented on the issue:

    https://github.com/apache/flink/pull/4355
  
    The new created method `open(ctx)` and `close()` of `GeneratedAggregations`  are not called
by `AggregateAggFunction` which is used in window aggregate.  I suggest to call the `open(ctx)`
method but pass a `RuntimeContext` which throw exceptions in every method to tell users `User
Defined AggregateFunction is not supported to call open() and close() in window`. But this
can be addressed in another issue. 
    
    BTW, I think the `AggregateCodeGenerator#generateAggregations` is too long with 500+ LOC.
I would like to refactor it if you have no objection @kaibozhou @fhueske .  I have created
[FLINK-7509](https://issues.apache.org/jira/browse/FLINK-7509) .


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message