flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7199) Graph simplification does not set parallelism
Date Thu, 10 Aug 2017 09:28:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121346#comment-16121346
] 

ASF GitHub Bot commented on FLINK-7199:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4346#discussion_r132402963
  
    --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/LongParameter.java
---
    @@ -52,16 +52,6 @@ public LongParameter(ParameterizedBase owner, String name) {
     	public LongParameter setDefaultValue(long defaultValue) {
     		super.setDefaultValue(defaultValue);
     
    -		if (hasMinimumValue) {
    -			Util.checkParameter(defaultValue >= minimumValue,
    -				"Default value (" + defaultValue + ") must be greater than or equal to minimum ("
+ minimumValue + ")");
    -		}
    -
    -		if (hasMaximumValue) {
    -			Util.checkParameter(defaultValue <= maximumValue,
    -				"Default value (" + defaultValue + ") must be less than or equal to maximum (" +
maximumValue + ")");
    -		}
    -
    --- End diff --
    
    I'm no expert here, but can you elaborate on why you removed these checks for the default
value being in line with the min and max?
    
    I can only guess that this must be that way in case where the default parallelism is not
within the bounds of the configured one. I'm wondering whether the `LongParameter` is used
somewhere else were these bounds are expected to hold though.


> Graph simplification does not set parallelism
> ---------------------------------------------
>
>                 Key: FLINK-7199
>                 URL: https://issues.apache.org/jira/browse/FLINK-7199
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The {{Simplify}} parameter should accept and set the parallelism when calling the {{Simplify}}
algorithms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message