flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor
Date Wed, 30 Aug 2017 16:20:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147538#comment-16147538

ASF GitHub Bot commented on FLINK-6864:

Github user greghogan commented on the issue:

    I also agree that these messages have been personally useful. I think this PR is an improvement
but that we could do better to note and/or emphasize the performance implications of `GenericType`.
I'm not sure that we even need to mention `GenericType` explicitly. I can see how the current
message could confuse users but explaining this as having performance implications should
clarify the reasoning for this being logged.

> Remove confusing "invalid POJO type" messages from TypeExtractor
> ----------------------------------------------------------------
>                 Key: FLINK-6864
>                 URL: https://issues.apache.org/jira/browse/FLINK-6864
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, Type Serialization System
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Fang Yong
> When a user's type cannot be treated as a POJO, the {{TypeExtractor}} will log warnings
such as ".. must have a default constructor to be used as a POJO.", "  ... is not a valid
POJO type because not all fields are valid POJO fields." in the {{analyzePojo}} method.
> These messages are often conceived as misleading for the user to think that the job should
have failed, whereas in fact in these cases Flink just fallsback to Kryo and treat then as
generic types. We should remove these messages, and at the same time improve the type serialization
docs at [1] to explicitly inform what it means when Flink does / does not recognizes a user
type as a POJO.
> [1] https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/types_serialization.html#rules-for-pojo-types

This message was sent by Atlassian JIRA

View raw message