flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...
Date Thu, 24 Aug 2017 21:54:43 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r135133385
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -161,13 +182,108 @@ class AggregationCodeGenerator(
             }
         }
     
    +    /**
    +      * Adds a reusable [[org.apache.flink.table.api.dataview.DataView]] to the open,
cleanup,
    +      * close and member area of the generated function.
    +      *
    +      */
    +    def addReusableDataViews: Unit = {
    +      if (accConfig != null && accConfig.isStateBackedDataViews) {
    +        val descMapping: Map[String, StateDescriptor[_, _]] = accConfig.accSpecs
    +          .flatMap(specs => specs.map(s => (s.id, s.toStateDescriptor)))
    +          .toMap[String, StateDescriptor[_, _]]
    +
    +        for (i <- aggs.indices) yield {
    +          for (spec <- accConfig.accSpecs(i)) yield {
    +            val dataViewField = spec.field
    +            val dataViewTypeTerm = dataViewField.getType.getCanonicalName
    +            val desc = descMapping.getOrElse(spec.id,
    +              throw new CodeGenException(s"Can not find ListView in accumulator by id:
${spec.id}"))
    --- End diff --
    
    The code is not `ListView` specific. Change to `DataView`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message