flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...
Date Thu, 24 Aug 2017 21:54:43 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r135112662
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/MapViewSerializer.scala
---
    @@ -0,0 +1,131 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.dataview
    +
    +import java.util
    +
    +import org.apache.flink.annotation.Internal
    +import org.apache.flink.api.common.typeutils._
    +import org.apache.flink.api.common.typeutils.base.{MapSerializer, MapSerializerConfigSnapshot}
    +import org.apache.flink.core.memory.{DataInputView, DataOutputView}
    +import org.apache.flink.table.api.dataview.MapView
    +
    +/**
    +  * A serializer for [[MapView]]. The serializer relies on a key serializer and a value
    +  * serializer for the serialization of the map's key-value pairs.
    +  *
    +  * <p>The serialization format for the map is as follows: four bytes for the length
of the map,
    +  * followed by the serialized representation of each key-value pair. To allow null values,
    +  * each value is prefixed by a null marker.
    +  *
    +  * @param mapSerializer Map serializer.
    +  * @tparam K The type of the keys in the map.
    +  * @tparam V The type of the values in the map.
    +  */
    +@Internal
    +class MapViewSerializer[K, V](val mapSerializer: MapSerializer[K, V])
    +  extends TypeSerializer[MapView[K, V]] {
    +
    +  override def isImmutableType: Boolean = false
    +
    +  override def duplicate(): TypeSerializer[MapView[K, V]] =
    +    new MapViewSerializer[K, V](
    +      mapSerializer.duplicate().asInstanceOf[MapSerializer[K, V]])
    +
    +  override def createInstance(): MapView[K, V] = {
    +    val mapview = new MapView[K, V]
    +    mapview.putAll(mapSerializer.createInstance())
    +    mapview
    +  }
    +
    +  override def copy(from: MapView[K, V]): MapView[K, V] = {
    +    val mapview = new MapView[K, V]
    +    mapview.putAll(mapSerializer.copy(from.map))
    --- End diff --
    
    Same as for `ListStateSerializer`. Copying one list into another is more expensive than
just replacing the list instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message