flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...
Date Tue, 22 Aug 2017 12:57:57 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4569#discussion_r134468988
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClientEndpoint.java
---
    @@ -155,38 +129,66 @@ public void shutdown() {
     			.set(HttpHeaders.Names.HOST, configuredTargetAddress + ":" + configuredTargetPort)
     			.set(HttpHeaders.Names.CONNECTION, HttpHeaders.Values.CLOSE);
     
    -		synchronized (this) {
    -			// This ensures strict sequential processing of requests.
    -			// If we send new requests immediately we can no longer make assumptions about the
order in which responses
    -			// arrive, due to which the handler cannot know which future he should complete (not
to mention what response
    -			// type to read).
    -			CompletableFuture<P> nextFuture = lastFuture
    -				.handleAsync((f, e) -> submitRequest(httpRequest, messageHeaders), directExecutor)
    -				.thenCompose((future) -> future);
    -
    -			lastFuture = nextFuture;
    -			return nextFuture;
    -		}
    +		return submitRequest(httpRequest, messageHeaders);
     	}
     
     	private <M extends MessageHeaders<R, P, U>, U extends ParameterMapper, R extends
RequestBody, P extends ResponseBody> CompletableFuture<P> submitRequest(FullHttpRequest
httpRequest, M messageHeaders) {
    -		CompletableFuture<P> responseFuture = handler.expectResponse(messageHeaders.getResponseClass());
    -
    -		try {
    -			// write request
    -			Channel channel = bootstrap.connect(configuredTargetAddress, configuredTargetPort).sync().channel();
    -			channel.writeAndFlush(httpRequest);
    -			channel.closeFuture();
    -		} catch (InterruptedException e) {
    -			return FutureUtils.completedExceptionally(e);
    +		synchronized (lock) {
    +			CompletableFuture<P> responseFuture = ClientHandler.addHandlerForResponse(bootstrap,
sslEngine, messageHeaders.getResponseClass());
    --- End diff --
    
    Can't we do it by having a fixed channel initializer which always creates a new `ClientHandler`?
Then we can retrieve the actual `ClientHandler` by `channel.pipeline.get(ClientHandler.class)`.
And then we can gain access to the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message