flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4558: [FLINK-7056][tests][hotfix] make sure the client a...
Date Thu, 17 Aug 2017 10:22:21 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4558#discussion_r133675837
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
    @@ -139,30 +139,35 @@ private static BlobKey prepareTestFile(File file) throws IOException
{
     	 * the specified buffer.
     	 * 
     	 * @param inputStream
    -	 *        the input stream returned from the GET operation
    +	 *        the input stream returned from the GET operation (will be closed by this method)
     	 * @param buf
     	 *        the buffer to compare the input stream's data to
     	 * @throws IOException
     	 *         thrown if an I/O error occurs while reading the input stream
     	 */
     	static void validateGet(final InputStream inputStream, final byte[] buf) throws IOException
{
    --- End diff --
    
    ok, why not... ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message