flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yestinchen <...@git.apache.org>
Subject [GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...
Date Wed, 16 Aug 2017 15:09:46 GMT
Github user yestinchen commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
    @@ -150,6 +160,29 @@ long getWindowTime() {
    +		 * Check pattern after match skip strategy.
    +		 */
    --- End diff --
    We only need to check the skip strategy before compile the `Pattern` to `NFA`, I think
it's more reasonable to place it here. Also, we need to check whether the `patternName` field
in the `AfterMatchSkipStrategy` is a valid reference, which can not be done easily in `Pattern`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message