flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zohar-mizrahi <...@git.apache.org>
Subject [GitHub] flink pull request #3838: [FLINK-5886] Python API for streaming applications
Date Wed, 16 Aug 2017 08:52:42 GMT
Github user zohar-mizrahi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3838#discussion_r133392462
  
    --- Diff: flink-libraries/flink-streaming-python/src/main/java/org/apache/flink/streaming/python/util/serialization/PyObjectSerializer.java
---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.python.util.serialization;
    +
    +import com.esotericsoftware.kryo.Kryo;
    +import com.esotericsoftware.kryo.Serializer;
    +import com.esotericsoftware.kryo.io.Input;
    +import com.esotericsoftware.kryo.io.Output;
    +import org.python.core.PyObject;
    +
    +import java.io.IOException;
    +
    +/**
    + * A serializer implementation for PyObject class type. Is is used by the Kryo serialization
    + * framework. {@see https://github.com/EsotericSoftware/kryo#serializers}
    + */
    +public class PyObjectSerializer extends Serializer<PyObject> {
    +
    +	public void write (Kryo kryo, Output output, PyObject po) {
    +		try {
    +			byte[] serPo = SerializationUtils.serializeObject(po);
    +			output.writeInt(serPo.length);
    +			output.write(serPo);
    +		} catch (IOException e) {
    +			e.printStackTrace();
    --- End diff --
    
    My bad - I missed the java unchecked exceptions part (.e.g runtime exception). It'll be
much better to use it here. 
    As for the `read`, we can either return `null` or again use the runtime exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message