flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zohar-mizrahi <...@git.apache.org>
Subject [GitHub] flink pull request #3838: [FLINK-5886] Python API for streaming applications
Date Tue, 15 Aug 2017 13:45:45 GMT
Github user zohar-mizrahi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3838#discussion_r133192783
  
    --- Diff: flink-libraries/flink-streaming-python/src/main/java/org/apache/flink/streaming/python/util/PythonCollector.java
---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.python.util;
    +
    +import org.apache.flink.annotation.Public;
    +import org.apache.flink.streaming.python.api.functions.UtilityFunctions;
    +import org.apache.flink.util.Collector;
    +import org.python.core.PyObject;
    +
    +/**
    + * Collects a {@code PyObject} record and forwards it. It makes sure that the record
is converted,
    + * if necessary, to a {@code PyObject}.
    + */
    +@Public
    +public class PythonCollector implements Collector<PyObject> {
    +	private Collector<PyObject> collector;
    +
    +	public void setCollector(Collector<PyObject> collector) {
    +		this.collector = collector;
    +	}
    +
    +	@Override
    +	public void collect(PyObject record) {
    +		PyObject po = UtilityFunctions.adapt(record);
    --- End diff --
    
    Actually you're right. This line can be dropped. And now, it seems that the `PythonCollector`
is redundant, though it provides a more safety layer to report users about casting problems
in case they provide UDF from the Java source code. If their function would not handle PyObject
that it will break in runtime, saying something like and object cannot be cast to 'PyObject'.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message