flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xccui <...@git.apache.org>
Subject [GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...
Date Sun, 13 Aug 2017 13:53:39 GMT
Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4532#discussion_r132842811
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
    @@ -719,33 +715,47 @@ abstract class TableEnvironment(val config: TableConfig) {
           throw new TableException("Field name can not be '*'.")
         }
     
    -    (fieldNames.toArray, fieldIndexes.toArray)
    +    (fieldNames.toArray, fieldIndexes.toArray) // build fails if not converted to array
    --- End diff --
    
    In my local environment, `toArray` also seems to be redundant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message