flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...
Date Fri, 11 Aug 2017 08:28:23 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4473#discussion_r132636582
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
    @@ -38,6 +39,23 @@
      * Utilities for Flink Kinesis connector configuration.
      */
     public class KinesisConfigUtil {
    +	/** Maximum number of items to pack into an PutRecords request. **/
    +	@Deprecated
    +	protected static final String COLLECTION_MAX_COUNT = "CollectionMaxCount";
    --- End diff --
    
    This doesn't require deprecation, as it isn't exposed to the user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message