flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bowenli86 <...@git.apache.org>
Subject [GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...
Date Thu, 10 Aug 2017 07:00:41 GMT
Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4473#discussion_r132376988
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java
---
    @@ -24,10 +24,28 @@
      */
     public class ProducerConfigConstants extends AWSConfigConstants {
     
    +	/** Deprecated key. **/
    +	public static final String DEPRECATED_COLLECTION_MAX_COUNT = "aws.producer.collectionMaxCount";
    +
    + 	/** Deprecated key. **/
    +	public static final String DEPRECATED_AGGREGATION_MAX_COUNT = "aws.producer.aggregationMaxCount";
    +
     	/** Maximum number of items to pack into an PutRecords request. **/
    -	public static final String COLLECTION_MAX_COUNT = "aws.producer.collectionMaxCount";
    +	public static final String COLLECTION_MAX_COUNT = "CollectionMaxCount";
    --- End diff --
    
    `CollectionMaxCount` and `AllocationMaxCount` will be `protected` since there's a unit
test using them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message