flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #4188: [FLINK-7009] dogstatsd mode in statds reporter
Date Wed, 09 Aug 2017 13:14:35 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4188
  
    Sorry that it's taking so long for me to response, I'm completely swamped with issues
at the moment.
    
    I will take another deeper look when i finally find time to try this out, but from what
I've seen so far it looks good.
    
    There are 3 changes that I would like to promote to general features of the metric system:
the short_ids option, the size limit and the replacement of object references.
    The names to tasks/operators can be modified in `TaskManagerMetricGroup#addTaskForJob()`
and `TaskMetricGroup#addOperator()`. The IDs can be modified in `TaskManagerMetricGroup#addTaskForJob()`
, `JobManagerMetricGroup#addJob(), and the constructor of `TaskManagerMetricGroup` for which
we ideally add a static factory method.
    
    Hence, I'm unsure on whether to merge this PR as is, or first implement the above and
then rebase the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message