flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...
Date Mon, 07 Aug 2017 19:11:32 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4488#discussion_r131739402
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
---
    @@ -172,45 +172,20 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem) extends JavaTypeFactoryImp
         *
         * @param fieldNames field names
         * @param fieldTypes field types, every element is Flink's [[TypeInformation]]
    -    * @param rowtime optional system field to indicate event-time; the index determines
the index
    -    *                in the final record. If the index is smaller than the number of
specified
    -    *                fields, it shifts all following fields.
    -    * @param proctime optional system field to indicate processing-time; the index determines
the
    -    *                 index in the final record. If the index is smaller than the number
of
    -    *                 specified fields, it shifts all following fields.
         * @return a struct type with the input fieldNames, input fieldTypes, and system fields
         */
       def buildLogicalRowType(
    --- End diff --
    
    I think it's still fine. It creates a row type for the logical (Calcite) plan. 
    But I'm fine changing the name if you have a better one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message