flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...
Date Mon, 07 Aug 2017 18:46:22 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
    @@ -148,6 +142,20 @@ class DataStreamGroupWindowAggregate(
             "state size. You may specify a retention time of 0 to not clean up the state.")
    +    val timestampedInput = if (isRowtimeAttribute(window.timeAttribute)) {
    +      // copy the window rowtime attribute into the StreamRecord timestamp field
    +      val timeAttribute = window.timeAttribute.asInstanceOf[ResolvedFieldReference].name
    +      val timeIdx = inputSchema.logicalFieldNames.indexOf(timeAttribute)
    --- End diff --
    I thought we can get rid of logical/physical distinction?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message