flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...
Date Mon, 07 Aug 2017 18:46:22 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4488#discussion_r131718272
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ProcTimeMaterializationSqlFunction.scala
---
    @@ -22,12 +22,12 @@ import org.apache.calcite.sql.`type`._
     import org.apache.calcite.sql.validate.SqlMonotonicity
     
     /**
    -  * Function that materializes a time attribute to the metadata timestamp. After materialization
    -  * the result can be used in regular arithmetical calculations.
    +  * Function that materializes a processing time attribute.
    +  * After materialization the result can be used in regular arithmetical calculations.
       */
    -object TimeMaterializationSqlFunction
    +object ProcTimeMaterializationSqlFunction
    --- End diff --
    
    Should we shorten this to `ProctimeSqlFunction`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message