flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...
Date Mon, 07 Aug 2017 06:11:39 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4473#discussion_r131577895
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
    @@ -169,14 +169,27 @@ public void open(Configuration parameters) throws Exception {
     
     		producerConfig.setRegion(configProps.getProperty(ProducerConfigConstants.AWS_REGION));
     		producerConfig.setCredentialsProvider(AWSUtil.getCredentialsProvider(configProps));
    -		if (configProps.containsKey(ProducerConfigConstants.COLLECTION_MAX_COUNT)) {
    -			producerConfig.setCollectionMaxCount(PropertiesUtil.getLong(configProps,
    -					ProducerConfigConstants.COLLECTION_MAX_COUNT, producerConfig.getCollectionMaxCount(),
LOG));
    -		}
    -		if (configProps.containsKey(ProducerConfigConstants.AGGREGATION_MAX_COUNT)) {
    -			producerConfig.setAggregationMaxCount(PropertiesUtil.getLong(configProps,
    -					ProducerConfigConstants.AGGREGATION_MAX_COUNT, producerConfig.getAggregationMaxCount(),
LOG));
    -		}
    +
    +		producerConfig.setAggregationMaxCount(PropertiesUtil.getLong(configProps,
    +				ProducerConfigConstants.AGGREGATION_MAX_COUNT, producerConfig.getAggregationMaxCount(),
LOG));
    +
    +		producerConfig.setCollectionMaxCount(PropertiesUtil.getLong(configProps,
    +				ProducerConfigConstants.COLLECTION_MAX_COUNT, producerConfig.getCollectionMaxCount(),
LOG));
    +
    +		producerConfig.setMaxConnections(PropertiesUtil.getLong(configProps,
    +				ProducerConfigConstants.MAX_CONNECTIONS, producerConfig.getMaxConnections(), LOG));
    +
    +		producerConfig.setRateLimit(PropertiesUtil.getLong(configProps,
    +			ProducerConfigConstants.RATE_LIMIT, producerConfig.getRateLimit(), LOG));
    --- End diff --
    
    Starting from this line, the indentation is not consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message