flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...
Date Tue, 01 Aug 2017 13:26:26 GMT
Github user NicoK commented on the issue:

    FYI: the `final` keyword on methods in `final` classes is something that is actually forbidden
by the checkstyle, hence the change
    Regarding the try-catch in tests (actually part of #4446): you're right, I was too quick
in arguing that stack traces are not printed - whenever there is a `e.printStackTrace()`,
it should work but at least when developing with IntelliJ, this printout is not clickable
(during debugging a failure) compared to failing with a proper exception.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message