flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...
Date Tue, 01 Aug 2017 13:02:38 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4447
  
    There is also a complete reorg of a test file, removing try/catch blocks. This affects
to my knowledge only the way where exactly the stack trace is printed.
    
    I am skeptical about these types of refactorings:
      - Either the reviewer does not really look at them, in which case the danger of accidentally
weakening the test coverage by far outweigh the (in my opinion quite subjective and cosmetic)
benefits of such a change.
      - Or the reviewer really checks the diff, in which case I would suggest to dedicate
that time to other pull requests that bring in actual improvements.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message