Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 06177200CCA for ; Wed, 19 Jul 2017 19:21:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 04887169751; Wed, 19 Jul 2017 17:21:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4A56016974D for ; Wed, 19 Jul 2017 19:21:04 +0200 (CEST) Received: (qmail 70687 invoked by uid 500); 19 Jul 2017 17:21:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 70678 invoked by uid 99); 19 Jul 2017 17:21:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jul 2017 17:21:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AB905C0326 for ; Wed, 19 Jul 2017 17:21:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 00w2feqntXTF for ; Wed, 19 Jul 2017 17:21:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7215560DB3 for ; Wed, 19 Jul 2017 17:21:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D5924E0E38 for ; Wed, 19 Jul 2017 17:21:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 41A2821EAC for ; Wed, 19 Jul 2017 17:21:00 +0000 (UTC) Date: Wed, 19 Jul 2017 17:21:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 19 Jul 2017 17:21:05 -0000 [ https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093455#comment-16093455 ] ASF GitHub Bot commented on FLINK-7134: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4362#discussion_r128310762 --- Diff: flink-connectors/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatInputFormatBase.java --- @@ -299,7 +301,7 @@ public InputSplitAssigner getInputSplitAssigner(HadoopInputSplit[] inputSplits) public void open(HadoopInputSplit split) throws IOException { TaskAttemptContext context = null; try { - context = HadoopUtils.instantiateTaskAttemptContext(configuration, new TaskAttemptID()); + context = new TaskAttemptContextImpl(configuration, new TaskAttemptID()); --- End diff -- Same as above... > Remove hadoop1.x code in mapreduce.utils.HadoopUtils > ---------------------------------------------------- > > Key: FLINK-7134 > URL: https://issues.apache.org/jira/browse/FLINK-7134 > Project: Flink > Issue Type: Improvement > Components: Java API > Reporter: mingleizhang > Assignee: mingleizhang > > This jira is similar to FLINK-7118. And for a clearer format and a review, I separated the two jira. -- This message was sent by Atlassian JIRA (v6.4.14#64029)