Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 10 Jul 2017 08:57:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13084510.1499166973000.205700.1499677022880@Atlassian.JIRA>
In-Reply-To: <JIRA.13084510.1499166973000@Atlassian.JIRA>
References: <JIRA.13084510.1499166973000@Atlassian.JIRA> <JIRA.13084510.1499166973224@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7099) Replace usages of deprecated
 JOB_MANAGER_IPC_PORT_KEY
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Jul 2017 09:24:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080041#comment-16080041 ] 

ASF GitHub Bot commented on FLINK-7099:
---------------------------------------

Github user zjureel commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4278#discussion_r126366568
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java ---
    @@ -185,8 +185,8 @@ public static WebMonitor startWebMonitorIfConfigured(
     
     		// this ensures correct values are present in the web frontend
     		final Address address = AkkaUtils.getAddress(actorSystem);
    -		config.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, address.host().get());
    -		config.setString(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY, address.port().get().toString());
    +		config.setString(JobManagerOptions.ADDRESS, address.host().get());
    +		config.setInteger(JobManagerOptions.PORT, Integer.parseInt(address.port().get().toString()));
    --- End diff --
    
    @zentol The returned value of `address.port().get()` in java is `Object` and I found it can't be used as `config.setInteger(JobManagerOptions.PORT, address.port().get()));` directly. Do you mean that we should use `config.setInteger(JobManagerOptions.PORT, (Integer)address.port().get()));` instead? Hoping to hear your suggestion, thanks 


> Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY
> -----------------------------------------------------
>
>                 Key: FLINK-7099
>                 URL: https://issues.apache.org/jira/browse/FLINK-7099
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, Local Runtime
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Fang Yong
>             Fix For: 1.4.0
>
>
> The deprecated {{ConfigConstants#JOB_MANAGER_IPC_PORT_KEY}} is still used a lot.
> We should replace these usages with {{JobManagerOptions#PORT}}.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)