Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8967166478 for ; Tue, 25 Jul 2017 10:32:04 +0200 (CEST) Received: (qmail 16569 invoked by uid 500); 25 Jul 2017 08:32:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 16554 invoked by uid 99); 25 Jul 2017 08:32:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jul 2017 08:32:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9DA2E1A086E for ; Tue, 25 Jul 2017 08:32:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.502 X-Spam-Level: X-Spam-Status: No, score=-99.502 tagged_above=-999 required=6.31 tests=[KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id VYYrQXO94R5e for ; Tue, 25 Jul 2017 08:32:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BFC6C5FE37 for ; Tue, 25 Jul 2017 08:32:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 07339E0E37 for ; Tue, 25 Jul 2017 08:32:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A2FE923F2E for ; Tue, 25 Jul 2017 08:32:00 +0000 (UTC) Date: Tue, 25 Jul 2017 08:32:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099709#comment-16099709 ] ASF GitHub Bot commented on FLINK-6429: --------------------------------------- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r129237531 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java --- @@ -1869,13 +1869,23 @@ private RexNode convertOver(Blackboard bb, SqlNode node) { // Walk over the tree and apply 'over' to all agg functions. This is // necessary because the returned expression is not necessarily a call // to an agg function. For example, AVG(x) becomes SUM(x) / COUNT(x). + --- End diff -- I think we can remove this file for now and rely on Calcite 1.13 implementation. We don't need it anymore. > Bump up Calcite version to 1.13 > ------------------------------- > > Key: FLINK-6429 > URL: https://issues.apache.org/jira/browse/FLINK-6429 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Timo Walther > Assignee: Haohui Mai > > This is an umbrella issue for all tasks that need to be done once Apache Calcite 1.13 is released. -- This message was sent by Atlassian JIRA (v6.4.14#64029)