Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 10 Jul 2017 13:03:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13066074.1492866930000.206932.1499691780393@Atlassian.JIRA>
In-Reply-To: <JIRA.13066074.1492866930000@Atlassian.JIRA>
References: <JIRA.13066074.1492866930000@Atlassian.JIRA> <JIRA.13066074.1492866930727@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6357) ParameterTool get unrequested
 parameters
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Jul 2017 13:03:06 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080293#comment-16080293 ] 

ASF GitHub Bot commented on FLINK-6357:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4169#discussion_r126413856
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java ---
    @@ -174,9 +210,38 @@ public void testUnrequestedByte() {
     
     		// test repeated access
     		Assert.assertEquals(1, parameter.getByte("byte"));
    +		Assert.assertEquals(Collections.emptySet(), parameter.getUnrequestedParameters());
    +	}
    +
    +	@Test
    +	public void testUnrequestedByteWithDefaultValue() {
    +		ParameterTool parameter = ParameterTool.fromArgs(new String[]{"-byte", "1"});
    +		Assert.assertEquals(Sets.newHashSet("byte"), parameter.getUnrequestedParameters());
    +
    +		// test parameter access
    +		Assert.assertEquals(1, parameter.getByte("byte", (byte) 0));
    +		Assert.assertEquals(Collections.emptySet(), parameter.getUnrequestedParameters());
    +
    +		// test repeated access
    +		Assert.assertEquals(1, parameter.getByte("byte", (byte) 0));
    +		Assert.assertEquals(Collections.emptySet(), parameter.getUnrequestedParameters());
     	}
     
     	@Test
    +	public void testUnrequestedByteWithMissingValue() {
    +		ParameterTool parameter = ParameterTool.fromArgs(new String[]{"-byte"});
    +		Assert.assertEquals(Sets.newHashSet("byte"), parameter.getUnrequestedParameters());
    +
    +		exception.expect(RuntimeException.class);
    +		exception.expectMessage("For input string: \"__NO_VALUE_KEY\"");
    +
    +		parameter.getByte("byte");
    +		Assert.assertEquals(Collections.emptySet(), parameter.getUnrequestedParameters());
    --- End diff --
    
    this code is not executed anymore, isn't it? `getByte()` will throw and JUnit will check for the expected exception but the following `Assert.assertEquals()` will (unfortunately) be ignored


> ParameterTool get unrequested parameters
> ----------------------------------------
>
>                 Key: FLINK-6357
>                 URL: https://issues.apache.org/jira/browse/FLINK-6357
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The Gelly examples use {{ParameterTool}} to parse required and optional parameters. In the latter case we should detect if a user mistypes a parameter name. I would like to add a {{Set<String> getUnrequestedParameters()}} method returning parameter names not requested by {{has}} or any of the {{get}} methods.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)