Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 43D02200CB9 for ; Sun, 2 Jul 2017 17:20:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 42212160BEE; Sun, 2 Jul 2017 15:20:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 88AC2160BD7 for ; Sun, 2 Jul 2017 17:20:08 +0200 (CEST) Received: (qmail 85164 invoked by uid 500); 2 Jul 2017 15:20:07 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 85155 invoked by uid 99); 2 Jul 2017 15:20:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jul 2017 15:20:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5B983C0617 for ; Sun, 2 Jul 2017 15:20:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OO0jt3YFfU8X for ; Sun, 2 Jul 2017 15:20:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2E6EB5FE6E for ; Sun, 2 Jul 2017 15:20:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D6B77E0D33 for ; Sun, 2 Jul 2017 15:20:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BA823245E0 for ; Sun, 2 Jul 2017 15:20:01 +0000 (UTC) Date: Sun, 2 Jul 2017 15:20:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-5851) Renaming AsyncCollector into ResultPromise/ResultFuture MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 02 Jul 2017 15:20:09 -0000 [ https://issues.apache.org/jira/browse/FLINK-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071686#comment-16071686 ] ASF GitHub Bot commented on FLINK-5851: --------------------------------------- GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4243 [FLINK-5851] [streaming API] Rename AsyncCollector into ResultFuture You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-5851 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4243.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4243 ---- commit f51c741562fe7191fa6afe88479422d36d27a2ab Author: zhangminglei Date: 2017-07-02T15:14:21Z [FLINK-5851] [streaming API] Rename AsyncCollector into ResultFuture ---- > Renaming AsyncCollector into ResultPromise/ResultFuture > ------------------------------------------------------- > > Key: FLINK-5851 > URL: https://issues.apache.org/jira/browse/FLINK-5851 > Project: Flink > Issue Type: Improvement > Components: DataStream API > Affects Versions: 1.2.0, 1.3.0 > Reporter: Till Rohrmann > Fix For: 1.4.0 > > > Currently, the async I/O API gives an {{AsyncCollector}} to an {{AsyncFunction}} implementation. The name does not really reflect what the {{AsyncCollector}} does since it does not collect but is actually a one time completable future. Therefore, I propose to rename the {{AsyncCollector}} into {{ResultPromise}} or {{ResultFuture}}. This is API changing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)