Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4289-flink@git.apache.org>
In-Reply-To: <git-pr-4289-flink@git.apache.org>
Subject: [GitHub] flink pull request #4289: [FLINK-7092] [mesos] Shutdown ResourceManager comp...
Content-Type: text/plain
Message-Id: <20170726092640.0BD85DFC33@git1-us-west.apache.org>
Date: Wed, 26 Jul 2017 09:26:40 +0000 (UTC)
archived-at: Wed, 26 Jul 2017 09:26:45 -0000

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4289#discussion_r129522676
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ---
    @@ -312,6 +312,48 @@ private void recoverWorkers() throws Exception {
     	}
     
     	@Override
    +	public void shutDown() throws Exception {
    +		// shut down all components
    +		if (taskMonitor != null) {
    +			try {
    +				actorSystem.stop(taskMonitor);
    +			} catch (Throwable tt) {
    +				LOG.error("Failed to stop taskMonitor", tt);
    --- End diff --
    
    We should rather add the caught exceptions as suppressed exceptions to a global exception. See `shutDownApplication` for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---