Return-Path: <issues-return-123905-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 024D6166B90
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 25 Jul 2017 15:30:44 +0200 (CEST)
Received: (qmail 19637 invoked by uid 500); 25 Jul 2017 13:30:44 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 19628 invoked by uid 99); 25 Jul 2017 13:30:44 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jul 2017 13:30:44 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A71971A088C
	for <issues@flink.apache.org>; Tue, 25 Jul 2017 13:30:43 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id 4r4NLd51H1Sk for <issues@flink.apache.org>;
	Tue, 25 Jul 2017 13:30:43 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id BF7F25FB98
	for <issues@flink.incubator.apache.org>; Tue, 25 Jul 2017 13:30:42 +0000 (UTC)
Received: (qmail 19614 invoked by uid 99); 25 Jul 2017 13:30:42 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jul 2017 13:30:42 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1F135E00C5; Tue, 25 Jul 2017 13:30:42 +0000 (UTC)
From: dawidwys <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4331-flink@git.apache.org>
In-Reply-To: <git-pr-4331-flink@git.apache.org>
Subject: [GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...
Content-Type: text/plain
Message-Id: <20170725133042.1F135E00C5@git1-us-west.apache.org>
Date: Tue, 25 Jul 2017 13:30:42 +0000 (UTC)

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4331#discussion_r129303933
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -551,18 +579,47 @@ private boolean isSelfIgnore(final StateTransition<T> edge) {
     								nextVersion,
     								startTimestamp);
     					}
    +
    +					switch (skipStrategy.getStrategy()) {
    +						case SKIP_PAST_LAST_ROW:
    +							if (nextState.isFinal()) {
    +								resultingComputationStates.add(createStartComputationState(computationState, outgoingEdges));
    +							}
    +							break;
    +						case SKIP_TO_FIRST:
    +							if (nextState.getName().equals(skipStrategy.getRpv()) &&
    +								!nextState.getName().equals(currentState.getName())) {
    +								ComputationState<T> startComputationState = createStartComputationState(computationState, outgoingEdges);
    +								if (callLevel > 0) {
    +									throw new RuntimeException("infinite loop! Will abort the match process, please rewrite your pattern query");
    +								}
    +								// feed current matched event to the state.
    +								Collection<ComputationState<T>> computationStates = computeNextStates(startComputationState, event, timestamp, callLevel++);
    --- End diff --
    
    Why do we feed the event?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---