Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3712-flink@git.apache.org>
In-Reply-To: <git-pr-3712-flink@git.apache.org>
Subject: [GitHub] flink pull request #3712: [FLINK-6281] Create TableSink for JDBC.
Content-Type: text/plain
Message-Id: <20170719202622.E1632E96EA@git1-us-west.apache.org>
Date: Wed, 19 Jul 2017 20:26:22 +0000 (UTC)
archived-at: Wed, 19 Jul 2017 20:26:28 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3712#discussion_r128219589
  
    --- Diff: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCAppendTableSinkBuilder.java ---
    @@ -0,0 +1,97 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.io.jdbc;
    +
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.util.Preconditions;
    +
    +import static org.apache.flink.api.java.io.jdbc.JDBCOutputFormat.DEFAULT_BATCH_INTERVAL;
    +
    +/**
    + * A builder to configure and build the JDBCAppendTableSink.
    + */
    +public class JDBCAppendTableSinkBuilder {
    +	private String username;
    +	private String password;
    +	private String driverName;
    +	private String dbURL;
    +	private String query;
    +	private int batchInterval = DEFAULT_BATCH_INTERVAL;
    +	private TypeInformation<?>[] fieldTypes;
    +
    +	public JDBCAppendTableSinkBuilder setUsername(String username) {
    +		this.username = username;
    +		return this;
    +	}
    +
    +	public JDBCAppendTableSinkBuilder setPassword(String password) {
    +		this.password = password;
    +		return this;
    +	}
    +
    +	public JDBCAppendTableSinkBuilder setDrivername(String drivername) {
    +		this.driverName = drivername;
    +		return this;
    +	}
    +
    +	public JDBCAppendTableSinkBuilder setDBUrl(String dbURL) {
    +		this.dbURL = dbURL;
    +		return this;
    +	}
    +
    +	public JDBCAppendTableSinkBuilder setQuery(String query) {
    +		this.query = query;
    +		return this;
    +	}
    +
    +	public JDBCAppendTableSinkBuilder setBatchInterval(int batchInterval) {
    --- End diff --
    
    IMO, interval has a temporal connotation. `batchInterval` -> `batchSize`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---