Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3712-flink@git.apache.org>
In-Reply-To: <git-pr-3712-flink@git.apache.org>
Subject: [GitHub] flink pull request #3712: [FLINK-6281] Create TableSink for JDBC.
Content-Type: text/plain
Message-Id: <20170711162821.77096E0468@git1-us-west.apache.org>
Date: Tue, 11 Jul 2017 16:28:21 +0000 (UTC)
archived-at: Tue, 11 Jul 2017 16:39:18 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3712#discussion_r126736740
  
    --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSinkTest.java ---
    @@ -0,0 +1,128 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.io.jdbc;
    +
    +import org.apache.flink.api.common.functions.RuntimeContext;
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.java.typeutils.RowTypeInfo;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.types.Row;
    +
    +import org.junit.After;
    +import org.junit.Test;
    +
    +import java.io.IOException;
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.PreparedStatement;
    +import java.sql.ResultSet;
    +
    +import static org.junit.Assert.assertArrayEquals;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertFalse;
    +import static org.junit.Assert.assertNotSame;
    +import static org.mockito.Mockito.doReturn;
    +import static org.mockito.Mockito.mock;
    +
    +/**
    + * Test for JDBCTableSink.
    + */
    +public class JDBCTableSinkTest extends JDBCTestBase {
    +	private static final String[] FIELD_NAMES = new String[]{"foo"};
    +	private static final TypeInformation[] FIELD_TYPES = new TypeInformation[]{
    +		BasicTypeInfo.STRING_TYPE_INFO
    +	};
    +
    +
    +	private JDBCOutputFormat jdbcOutputFormat;
    +
    +	@After
    +	public void tearDown() throws IOException {
    +		if (jdbcOutputFormat != null) {
    +			jdbcOutputFormat.close();
    +		}
    +		jdbcOutputFormat = null;
    +	}
    +
    +	@Test
    +	public void testFlush() throws Exception {
    --- End diff --
    
    This tests rather the `JdbcOutputFormat.flush()` method. I would move (and adapt) this test to the `JdbcOutputFormatTest`.
    
    For the `JdbcTableSink` we need tests that check the configuration (which is done below) and a check that the `emitDataStream()` method (and the returned `SinkFunction`) is working correctly. I would do this by calling `emitDataStream()` with a mocked `DataStream<Row>` and fetching the `SinkFunction` from the returned `DataStreamSink` (`sink.getTransformation().getOperator().getUserFunction()`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---