Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 12ECA200CBB for ; Tue, 4 Jul 2017 12:22:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0ED29160CF9; Tue, 4 Jul 2017 10:22:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 53537160CF3 for ; Tue, 4 Jul 2017 12:22:06 +0200 (CEST) Received: (qmail 92178 invoked by uid 500); 4 Jul 2017 10:22:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 92169 invoked by uid 99); 4 Jul 2017 10:22:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jul 2017 10:22:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 48C8B180354 for ; Tue, 4 Jul 2017 10:22:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id rLZYy_2otmM7 for ; Tue, 4 Jul 2017 10:22:03 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 854AB5F39D for ; Tue, 4 Jul 2017 10:22:02 +0000 (UTC) Received: (qmail 92112 invoked by uid 99); 4 Jul 2017 10:22:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jul 2017 10:22:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0968DDF9C5; Tue, 4 Jul 2017 10:21:59 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #4220: [FLINK-6665] Pass a ScheduledExecutorService to the Resta... Content-Type: text/plain Message-Id: <20170704102200.0968DDF9C5@git1-us-west.apache.org> Date: Tue, 4 Jul 2017 10:21:59 +0000 (UTC) archived-at: Tue, 04 Jul 2017 10:22:07 -0000 Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4220 We have to also consider anther aspect: Changing this from a synchronous call to an asynchronous callback makes new types of races possible, against which we need to guard. We need to make sure that the `restart()` call cannot succeed if there was another cycle of failure that goes into `RESTARTING`. I would suggest to address https://issues.apache.org/jira/browse/FLINK-6667 first, so that the callback can check that the `globalModVersion` is unchanged upon restart. Then there is no anger in moving this to an asynchronous callback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---