flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4401: [hotfix][tests] minor test improvements in TaskMan...
Date Wed, 26 Jul 2017 10:23:06 GMT
GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4401

    [hotfix][tests] minor test improvements in TaskManagerConfigurationTest

    * use a proper JUnit temporary folder that ensures uniqueness
    * do not catch an exception just to fail with its message - if we let it throw, we do
get more information out of the failure
    * also re-set the default file system scheme (a static member!) after finishing the test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink hotfix_tm_conf_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4401
    
----
commit 341c3cb205238af971ce62522d5520098f3aca41
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-07-26T10:02:59Z

    [hotfix][tests] minor test improvements in TaskManagerConfigurationTest
    
    * use a proper JUnit temporary folder that ensures uniqueness
    * do not catch an exception just to fail with its message - if we let it throw,
    we do get more information out of the failure
    * also re-set the default file system scheme (a static member!) after finishing
    the test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message