flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7226) REST responses contain invalid content-encoding header
Date Tue, 25 Jul 2017 14:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100101#comment-16100101
] 

ASF GitHub Bot commented on FLINK-7226:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4392#discussion_r129317438
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobCancellationWithSavepointHandlers.java
---
    @@ -266,7 +266,7 @@ public void onComplete(Throwable failure, Object resp) throws Throwable
{
     
     			response.headers().set(HttpHeaders.Names.LOCATION, location);
     
    -			response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json");
    +			response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json; charset=UTF-8");
    --- End diff --
    
    Should this also use `ENCODING.name()`?


> REST responses contain invalid content-encoding header
> ------------------------------------------------------
>
>                 Key: FLINK-7226
>                 URL: https://issues.apache.org/jira/browse/FLINK-7226
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: 1.2.0, 1.1.4, 1.3.1, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0, 1.3.2
>
>
> FLINK-5705 made changes to the {{RuntimeMonitorHandler}} to set the {{content-encoding}}
header to {{UTF-8}}. This however isn't a valid value for this header, and should instead
be included in the {{content-type}} header.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message