flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG
Date Mon, 31 Jul 2017 21:05:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107951#comment-16107951
] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r130458506
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -179,13 +214,19 @@ class AggregationCodeGenerator(
                    |      ${aggMapping(i)},
                    |      (${accTypes(i)}) accs.getField($i));""".stripMargin
               } else {
    +            val setDataView = if (accConfig.isDefined && accConfig.get.isUseState)
{
    --- End diff --
    
    This will create new `MapState` (or `ListState`) objects in every invocation of `setAggregationResults()`.
I think we can make the state objects members of the `GeneratedAggregations` class and just
set them into the accumulator.


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message