flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG
Date Fri, 28 Jul 2017 16:15:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105207#comment-16105207
] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r130059497
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/HeapViewFactory.scala
---
    @@ -0,0 +1,88 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.dataview
    +
    +import java.lang.{Iterable => JIterable}
    +import java.util
    +
    +import org.apache.flink.api.common.state.{ListStateDescriptor, MapStateDescriptor, StateDescriptor}
    +import org.apache.flink.table.api.dataview.{ListView, MapView}
    +
    +/**
    +  * Heap view factory to create [[HeapListView]] or [[HeapMapView]].
    +  *
    +  */
    +class HeapViewFactory() extends DataViewFactory() {
    +
    +  override protected def createListView[T](id: String): ListView[T] = new HeapListView[T]
    +
    +  override protected def createMapView[K, V](id: String): MapView[K, V] = new HeapMapView[K,
V]
    +}
    +
    +class HeapListView[T] extends ListView[T] {
    +
    +  val list = new util.ArrayList[T]()
    +
    +  def this(t: util.List[T]) = {
    +    this()
    +    list.addAll(t)
    +  }
    +
    +  override def get: JIterable[T] = {
    +    if (!list.isEmpty) {
    +      list
    +    } else {
    +      null
    +    }
    +  }
    +
    +  override def add(value: T): Unit = list.add(value)
    +
    +  override def clear(): Unit = list.clear()
    +}
    +
    +class HeapMapView[K, V] extends MapView[K, V] {
    --- End diff --
    
    Could this be the default implementation of `MapView`?


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message