flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7199) Graph simplification does not set parallelism
Date Tue, 25 Jul 2017 12:14:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099941#comment-16099941
] 

ASF GitHub Bot commented on FLINK-7199:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4346#discussion_r129286498
  
    --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Simplify.java
---
    @@ -109,21 +109,23 @@ public Ordering getValue() {
     	 * @return output graph
     	 * @throws Exception on error
     	 */
    -	public <T extends Comparable<T>> Graph<T, NullValue, NullValue> simplify(Graph<T,
NullValue, NullValue> graph)
    +	public <T extends Comparable<T>> Graph<T, NullValue, NullValue> simplify(Graph<T,
NullValue, NullValue> graph, int parallelism)
     			throws Exception {
    -
     		switch (value) {
     			case DIRECTED:
     				graph = graph
    -					.run(new org.apache.flink.graph.asm.simple.directed.Simplify<T, NullValue, NullValue>());
    +					.run(new org.apache.flink.graph.asm.simple.directed.Simplify<T, NullValue, NullValue>()
    +						.setParallelism(parallelism));
    --- End diff --
    
    This is consistent throughout Gelly as we often chain operators.


> Graph simplification does not set parallelism
> ---------------------------------------------
>
>                 Key: FLINK-7199
>                 URL: https://issues.apache.org/jira/browse/FLINK-7199
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The {{Simplify}} parameter should accept and set the parallelism when calling the {{Simplify}}
algorithms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message