flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io
Date Fri, 14 Jul 2017 17:24:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087629#comment-16087629
] 

ASF GitHub Bot commented on FLINK-7185:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4340#discussion_r127504763
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/PrintingOutputFormat.java
---
    @@ -18,12 +18,16 @@
     
     package org.apache.flink.api.java.io;
     
    -import java.io.PrintStream;
    -
     import org.apache.flink.annotation.PublicEvolving;
     import org.apache.flink.api.common.io.RichOutputFormat;
     import org.apache.flink.configuration.Configuration;
     
    +import java.io.PrintStream;
    +
    +/**
    + * Output format that prints results into underlying {@link PrintStream}.
    --- End diff --
    
    I would reword this to mention stdout/stderr; the usage of `PrintStream` is an (unimportant)
implementation detail.


> Activate checkstyle flink-java/io
> ---------------------------------
>
>                 Key: FLINK-7185
>                 URL: https://issues.apache.org/jira/browse/FLINK-7185
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message