flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io
Date Fri, 14 Jul 2017 17:24:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087628#comment-16087628
] 

ASF GitHub Bot commented on FLINK-7185:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4340#discussion_r127505784
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/TextOutputFormat.java
---
    @@ -18,65 +18,73 @@
     
     package org.apache.flink.api.java.io;
     
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.io.FileOutputFormat;
    +import org.apache.flink.core.fs.Path;
    +
     import java.io.IOException;
     import java.io.Serializable;
     import java.nio.charset.Charset;
     import java.nio.charset.IllegalCharsetNameException;
     import java.nio.charset.UnsupportedCharsetException;
     
    -import org.apache.flink.annotation.PublicEvolving;
    -import org.apache.flink.api.common.io.FileOutputFormat;
    -import org.apache.flink.core.fs.Path;
    -
    +/**
    + * {@link FileOutputFormat} that stores values by calling {@link Object#toString()} method.
    + * @param <T> type of elements
    + */
     @PublicEvolving
     public class TextOutputFormat<T> extends FileOutputFormat<T> {
     
     	private static final long serialVersionUID = 1L;
    -	
    +
     	private static final int NEWLINE = '\n';
     
     	private String charsetName;
    -	
    +
     	private transient Charset charset;
     
     	// --------------------------------------------------------------------------------------------
     
    -	public static interface TextFormatter<IN> extends Serializable {
    -		public String format(IN value);
    +
    +	/**
    +	 * Formatter that transforms values into its {@link String} representations.
    --- End diff --
    
    into its -> into their


> Activate checkstyle flink-java/io
> ---------------------------------
>
>                 Key: FLINK-7185
>                 URL: https://issues.apache.org/jira/browse/FLINK-7185
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message