flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.
Date Wed, 12 Jul 2017 12:49:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083922#comment-16083922
] 

ASF GitHub Bot commented on FLINK-7162:
---------------------------------------

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/4311

    [FLINK-7162] [test] Tests should not write outside 'target' directory

    A few tests use ```Files.createTempDir()``` from Guava package, but do not set java.io.tmpdir
system property. Thus the temp directory is created in unpredictable places and is not being
cleaned up by ```mvn clean```.
    This was probably introduced in ```JobManagerStartupTest``` and then replicated in ```BlobUtilsTest```.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-7162

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4311.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4311
    
----
commit 159af161e6b3f5957731bc0ffb13e52afd1ef726
Author: zhangminglei <zml13856086071@163.com>
Date:   2017-07-12T12:46:21Z

    [FLINK-7162] [test] Tests should not write outside 'target' directory

----


> Tests should not write outside 'target' directory.
> --------------------------------------------------
>
>                 Key: FLINK-7162
>                 URL: https://issues.apache.org/jira/browse/FLINK-7162
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: mingleizhang
>            Assignee: mingleizhang
>
> A few tests use Files.createTempDir() from Guava package, but do not set java.io.tmpdir
system property. Thus the temp directory is created in unpredictable places and is not being
cleaned up by {{mvn clean}}.
> This was probably introduced in {{JobManagerStartupTest}} and then replicated in {{BlobUtilsTest}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message