flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7126) Support Distinct for Stream SQL and Table API
Date Tue, 11 Jul 2017 07:48:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081828#comment-16081828
] 

ASF GitHub Bot commented on FLINK-7126:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4279#discussion_r126617388
  
    --- Diff: docs/dev/table/tableApi.md ---
    @@ -373,7 +373,7 @@ Table result = orders
         <tr>
           <td>
             <strong>Distinct</strong><br>
    -        <span class="label label-primary">Batch</span>
    +        <span class="label label-primary">Batch</span> <span class="label
label-primary">Streaming</span>
    --- End diff --
    
    If the input is append/insert only, distinct will only produce insert changes as well.

    However, I don't think we make this distinction in the decoration phase. AFAIK, it will
always be marked to produce updates right now.
    
    IMO, it would be good if DISTINCT on append-only input would not be treated as producing
updates. We don't have to fix it in this PR, but I think it would be good to make such a change.
What do you think @wuchong?


> Support Distinct for Stream SQL and Table API
> ---------------------------------------------
>
>                 Key: FLINK-7126
>                 URL: https://issues.apache.org/jira/browse/FLINK-7126
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message