flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7125) Remove configuration loading from AbstractYarnClusterDescriptor
Date Thu, 27 Jul 2017 08:18:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102906#comment-16102906
] 

ASF GitHub Bot commented on FLINK-7125:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4280#discussion_r129769550
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
    @@ -58,7 +58,7 @@ public void addGeneralOptions(Options baseOptions) {
     	}
     
     	@Override
    -	public StandaloneClusterClient retrieveCluster(CommandLine commandLine, Configuration
config) {
    +	public StandaloneClusterClient retrieveCluster(CommandLine commandLine, Configuration
config, String configurationDirectory) {
    --- End diff --
    
    nit: maybe wrap params?


> Remove configuration loading from AbstractYarnClusterDescriptor
> ---------------------------------------------------------------
>
>                 Key: FLINK-7125
>                 URL: https://issues.apache.org/jira/browse/FLINK-7125
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> We should remove the explicit configuration loading from the {{AbstractYarnClusterDescriptor}}
and instead pass it to the class via the constructor. This passed in configuration should
then be sent to the application master when being started. That way, we can easily configure
the started Yarn cluster.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message