flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7113) Make ClusterDescriptor independent of Flink cluster size
Date Wed, 26 Jul 2017 10:07:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101478#comment-16101478

ASF GitHub Bot commented on FLINK-7113:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
    @@ -631,12 +634,15 @@ protected static void sendOutput() {
     	protected static class Runner extends Thread {
     		private final String[] args;
     		private final int expectedReturnValue;
    +		private final org.apache.flink.configuration.Configuration configuration;
     		private RunTypes type;
     		private FlinkYarnSessionCli yCli;
     		private Throwable runnerError;
    -		public Runner(String[] args, RunTypes type, int expectedReturnValue) {
    +		public Runner(String[] args, org.apache.flink.configuration.Configuration configuration,
RunTypes type, int expectedReturnValue) {
    --- End diff --
    True. Then I think it is not needed.

> Make ClusterDescriptor independent of Flink cluster size
> --------------------------------------------------------
>                 Key: FLINK-7113
>                 URL: https://issues.apache.org/jira/browse/FLINK-7113
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
> The {{ClusterDescriptor}} needs to know the size of the Flink cluster it is supposed
to deploy. As a consequence we have the {{AbstractYarnClusterDescriptor}} which is configured
with this information via setters. I think it would be better to give the cluster size to
the {{ClusterDescriptor}} via the {{deploySession(ClusterSpecification)}} call. That way we
better decouple the deployment from the cluster configuration.

This message was sent by Atlassian JIRA

View raw message