flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7113) Make ClusterDescriptor independent of Flink cluster size
Date Wed, 26 Jul 2017 09:42:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101453#comment-16101453
] 

ASF GitHub Bot commented on FLINK-7113:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4271#discussion_r129526492
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
---
    @@ -0,0 +1,81 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client.deployment;
    +
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.JobManagerOptions;
    +import org.apache.flink.configuration.TaskManagerOptions;
    +
    +/**
    + * Description of the cluster to start by the {@link ClusterDescriptor}.
    + */
    +public class ClusterSpecification {
    +	private final int masterMemoryMB;
    +	private final int taskManagerMemoryMB;
    +	private final int numberTaskManagers;
    +	private final int slotsPerTaskManager;
    +
    +	public ClusterSpecification(int masterMemoryMB, int taskManagerMemoryMB, int numberTaskManagers,
int slotsPerTaskManager) {
    +		this.masterMemoryMB = masterMemoryMB;
    +		this.taskManagerMemoryMB = taskManagerMemoryMB;
    +		this.numberTaskManagers = numberTaskManagers;
    +		this.slotsPerTaskManager = slotsPerTaskManager;
    +	}
    +
    +	public int getMasterMemoryMB() {
    +		return masterMemoryMB;
    +	}
    +
    +	public int getTaskManagerMemoryMB() {
    +		return taskManagerMemoryMB;
    +	}
    +
    +	public int getNumberTaskManagers() {
    +		return numberTaskManagers;
    +	}
    +
    +	public int getSlotsPerTaskManager() {
    +		return slotsPerTaskManager;
    +	}
    +
    +	@Override
    +	public String toString() {
    +		return "ClusterSpecification{" +
    +			"masterMemoryMB=" + masterMemoryMB +
    +			", taskManagerMemoryMB=" + taskManagerMemoryMB +
    +			", numberTaskManagers=" + numberTaskManagers +
    +			", slotsPerTaskManager=" + slotsPerTaskManager +
    +			'}';
    +	}
    +
    +	public static ClusterSpecification fromConfiguration(Configuration configuration) {
    +		int slots = configuration.getInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, 1);
    +
    +		int jobManagerMemoryMb = configuration.getInteger(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY);
    +		int taskManagerMemoryMb = configuration.getInteger(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY);
    +
    +
    --- End diff --
    
    Good catch.


> Make ClusterDescriptor independent of Flink cluster size
> --------------------------------------------------------
>
>                 Key: FLINK-7113
>                 URL: https://issues.apache.org/jira/browse/FLINK-7113
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{ClusterDescriptor}} needs to know the size of the Flink cluster it is supposed
to deploy. As a consequence we have the {{AbstractYarnClusterDescriptor}} which is configured
with this information via setters. I think it would be better to give the cluster size to
the {{ClusterDescriptor}} via the {{deploySession(ClusterSpecification)}} call. That way we
better decouple the deployment from the cluster configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message