flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7099) Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY
Date Mon, 10 Jul 2017 07:06:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079951#comment-16079951
] 

ASF GitHub Bot commented on FLINK-7099:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4278#discussion_r126346815
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java
---
    @@ -91,12 +91,11 @@ public static void submitTopology(final String name, final Map stormConf,
final
     		final Configuration flinkConfig = GlobalConfiguration.loadConfiguration();
     		if (!stormConf.containsKey(Config.NIMBUS_HOST)) {
     			stormConf.put(Config.NIMBUS_HOST,
    -					flinkConfig.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, "localhost"));
    +					flinkConfig.getString(JobManagerOptions.ADDRESS, "localhost"));
     		}
     		if (!stormConf.containsKey(Config.NIMBUS_THRIFT_PORT)) {
     			stormConf.put(Config.NIMBUS_THRIFT_PORT,
    -					new Integer(flinkConfig.getInteger(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY,
    --- End diff --
    
    sounds good.


> Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY
> -----------------------------------------------------
>
>                 Key: FLINK-7099
>                 URL: https://issues.apache.org/jira/browse/FLINK-7099
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, Local Runtime
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Fang Yong
>             Fix For: 1.4.0
>
>
> The deprecated {{ConfigConstants#JOB_MANAGER_IPC_PORT_KEY}} is still used a lot.
> We should replace these usages with {{JobManagerOptions#PORT}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message