flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ufuk Celebi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7067) Cancel with savepoint does not restart checkpoint scheduler on failure
Date Fri, 21 Jul 2017 10:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096109#comment-16096109
] 

Ufuk Celebi commented on FLINK-7067:
------------------------------------

I agree with Stephan's opinion. That's why I also have the test as a separate commit and corresponding
comments in the tests/PR description.

I think for the bugfix release, we have two options:
1) Merge it as is including the test
2) Merge it without the test

Option 3) would be to refactor the tests, but unfortunately I think that requires refactoring
the main line code. Maybe [~StephanEwen] has an idea to do this or adjust the test without
much overhead?


> Cancel with savepoint does not restart checkpoint scheduler on failure
> ----------------------------------------------------------------------
>
>                 Key: FLINK-7067
>                 URL: https://issues.apache.org/jira/browse/FLINK-7067
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.3.1
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>            Priority: Blocker
>             Fix For: 1.3.2
>
>
> The `CancelWithSavepoint` action of the JobManager first stops the checkpoint scheduler,
then triggers a savepoint, and cancels the job after the savepoint completes.
> If the savepoint fails, the command should not have any side effects and we don't cancel
the job. The issue is that the checkpoint scheduler is not restarted though.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message