flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback
Date Sat, 08 Jul 2017 14:40:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079172#comment-16079172
] 

ASF GitHub Bot commented on FLINK-6998:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4187#discussion_r126283335
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
    @@ -184,6 +186,18 @@
     	/** Flag indicating whether the consumer is still running. */
     	private volatile boolean running = true;
     
    +    // ------------------------------------------------------------------------
    --- End diff --
    
    The indentation is off by 1 space.


> Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka
Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6998
>                 URL: https://issues.apache.org/jira/browse/FLINK-6998
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Zhenzhong Xu
>            Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in KafkaConsumerThread
class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message