flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6964) Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore
Date Tue, 11 Jul 2017 15:22:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082373#comment-16082373
] 

ASF GitHub Bot commented on FLINK-6964:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4192#discussion_r126720581
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java
---
    @@ -391,7 +392,7 @@ private static KeyedStateHandle deserializeKeyedStateHandle(DataInputStream
dis)
     			Map<StateHandleID, StreamStateHandle> privateStates = deserializeStreamStateHandleMap(dis);
     
     			return new IncrementalKeyedStateHandle(
    -				operatorId,
    +				UUID.fromString(operatorId),
    --- End diff --
    
    This is not an operator ID anymore, right? Probably the local variable name should change.


> Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-6964
>                 URL: https://issues.apache.org/jira/browse/FLINK-6964
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Blocker
>             Fix For: 1.3.2
>
>
> {{StandaloneCompletedCheckpointStore}} does not register shared states ion resume. However,
for externalized checkpoints, it register the checkpoint from which it resumed. This checkpoint
gets added to the completed checkpoint store as part of resume.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message