flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator
Date Fri, 14 Jul 2017 12:49:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087266#comment-16087266
] 

ASF GitHub Bot commented on FLINK-6887:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4171#discussion_r127444349
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala
---
    @@ -155,7 +155,7 @@ trait CommonCorrelate {
           //   The generated expression is discarded.
           generator.generateExpression(condition.get.accept(changeInputRefIndexShuttle))
     
    -      val filterGenerator = new CodeGenerator(config, false, udtfTypeInfo, None, pojoFieldMapping)
    +      val filterGenerator = new FunctionCodeGenerator(config, false, udtfTypeInfo, None,
pojoFieldMapping)
    --- End diff --
    
    line exceeds limit of 100 chars


> Split up CodeGenerator into several specific CodeGenerator
> ----------------------------------------------------------
>
>                 Key: FLINK-6887
>                 URL: https://issues.apache.org/jira/browse/FLINK-6887
>             Project: Flink
>          Issue Type: Task
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> Currently, the {{CodeGenerator}} is very huge and a bit difficult to maintain. I suggest
to split it up into several specific {{XXXCodeGenerator}}.
> For example, create {{AggregationFunctionCodeGenerator}}  class and make it extend to
{{CodeGenerator}} and move the {{def generateAggregations(...)}} method to it. The same as
{{TableFunctionCollectorCodeGenerator}} and {{InputFormatCodeGenerator}}.
> What do you think? [~fhueske], [~twalthr], [~sunjincheng121]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message