flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6731) Activate strict checkstyle for flink-tests
Date Wed, 12 Jul 2017 11:23:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083828#comment-16083828
] 

ASF GitHub Bot commented on FLINK-6731:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4295#discussion_r126928245
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java
---
    @@ -1035,4 +1040,43 @@ public void restoreState(Integer state) throws Exception {
     			counterPartitions.add(state);
     		}
     	}
    +
    +	/**
    +	 * Copied from io.netty.util.internal.ConcurrentSet.
    +	 *
    +	 * @param <E> the type of elements maintained by this set
    +	 */
    +	private static final class ConcurrentSet<E> extends AbstractSet<E> implements
Serializable {
    --- End diff --
    
    This dependency was removed in a recent commit so am deleting the class.


> Activate strict checkstyle for flink-tests
> ------------------------------------------
>
>                 Key: FLINK-6731
>                 URL: https://issues.apache.org/jira/browse/FLINK-6731
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Chesnay Schepler
>            Assignee: Greg Hogan
>
> Long term issue for incrementally introducing the strict checkstyle to flink-tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message