flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6649) Improve Non-window group aggregate with configurable `earlyFire`.
Date Mon, 03 Jul 2017 16:44:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072694#comment-16072694
] 

ASF GitHub Bot commented on FLINK-6649:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4157#discussion_r125281365
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
    @@ -37,6 +37,13 @@ class BatchQueryConfig private[table] extends QueryConfig
     class StreamQueryConfig private[table] extends QueryConfig {
     
       /**
    +    * The non-windowed groupby aggregate update the calculation result according a configuration
of
    +    * time interval. By default non-windowed groupby aggregate will update calculation
result each
    +    * row.
    +    */
    +  private var unboundedAggregateUpdateInterval: Time = Time.milliseconds(0)
    --- End diff --
    
    I would not make this parameter specific for unbounded aggregates but use it for all types
of (supported) operators. The output of a query will always be synced to the slowest update
rate.
    
    Hence I propose to rename the parameter to `updateRate` or `updateInterval`.


> Improve Non-window group aggregate with configurable `earlyFire`.
> -----------------------------------------------------------------
>
>                 Key: FLINK-6649
>                 URL: https://issues.apache.org/jira/browse/FLINK-6649
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> Currently,  Non-windowed group aggregate is earlyFiring at count(1), that is every row
will emit a aggregate result. But some times user want config count number (`early firing
with count[N]`) , to reduce the downstream pressure. This JIRA. will enable the config of
e`earlyFiring` for  Non-windowed group aggregate.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message